Fixed opnorm #56500
Open
Fixed opnorm #56500
+140
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making a test case use `isapprox` instead of `==`.
andreasnoack
commented
Nov 8, 2024
|
Is CI currently broken? The failures look unrelated to any changes here. |
|
I restarted the failed job - let's see if the retry passes. |
|
Hmmm. The failure persists after a retry. |
|
Keno suggests that this has been fixed on master, so perhaps we need to rebase this PR again? |
|
FYI, the PowerPC jobs will likely fail here. This is a known issue, and is not related to this PR. |
|
@dgleich would you be able to rebase the branch? I tried but there are conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rebased version of #30138