Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.10: bump SparseArrays to latest v1.10 #56543

Open
wants to merge 2 commits into
base: release-1.10
Choose a base branch
from

Conversation

KristofferC
Copy link
Member

No description provided.

@KristofferC
Copy link
Member Author

@gbaraldi, @ViralBShah, @wsmoses, seems like this changed what error is thrown (SparseArrays does type piracy).


Test Failed at /cache/build/tester-demeter6-8/julialang/julia-release-1-dot-10/julia-4612e1ec04/share/julia/test/abstractarray.jl:1343
--
  | Expression: [t...; 3 4 5]
  | Expected: ArgumentError
  | Thrown: DimensionMismatch

@wsmoses
Copy link
Contributor

wsmoses commented Nov 13, 2024

I have no idea why that would change, but looking at the test, if anything that error feels more consistent?

from https://github.com/JuliaLang/julia/blob/9ee861f2806319e3575afe676d563d2a7a0bd8e2/test/abstractarray.jl#L1339C1-L1349C1

@testset "splatting into hvcat" begin
    t = (1, 2)
    @test [t...; 3 4] == [1 2; 3 4]
    @test [0 t...; t... 0] == [0 1 2; 1 2 0]
    @test_throws ArgumentError [t...; 3 4 5]

    @test Int[t...; 3 4] == [1 2; 3 4]
    @test Int[0 t...; t... 0] == [0 1 2; 1 2 0]
    @test_throws DimensionMismatch Int[t...; 3 4 5]
end

@wsmoses
Copy link
Contributor

wsmoses commented Nov 13, 2024

per 8fd5f27 which made the second case return DimensionMismatch I suppose the change might have made things more stable and/or now return a better error?

cc @vtjnash

@wsmoses
Copy link
Contributor

wsmoses commented Nov 13, 2024

lmao wat


Error in testset abstractarray:
--
  | Test Failed at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-XC9YQX9HH2.0/build/default-honeycrisp-XC9YQX9HH2-0/julialang/julia-release-1-dot-10/julia-0fd4c3c042/share/julia/test/abstractarray.jl:1343
  | Expression: [t...; 3 4 5]
  | Expected: DimensionMismatch
  | Thrown: ArgumentError

@KristofferC
Copy link
Member Author

It depends on if SparseArrays have been loaded or not into the worker because SparseArrays does type piracy on xcat (#56543 (comment)).

So the error thrown has to be consistent between Base and SparseArrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants