Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If nightly or pr check is going slowly inform user #1097

Merged
merged 6 commits into from
Nov 23, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Nov 2, 2024

I just happened to hit this in the wild:

Screenshot 2024-11-03 at 9 53 05 AM

Helps explain #1096 to the user

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@IanButterworth

This comment was marked as resolved.

IanButterworth and others added 3 commits November 2, 2024 15:16
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@IanButterworth IanButterworth changed the title If nightly check is going slowly inform user If nightly or pr check is going slowly inform user Nov 3, 2024
@IanButterworth
Copy link
Member Author

Bump

@davidanthoff
Copy link
Collaborator

I guess we can merge this for now, but somehow this makes me think that we maybe should just adopt tokio for the juliaup binary and then do this using async features... For example, the Windows download API is already completely async, so it really shouldn't be necessary to use extra threads to do something like that, and reqwest also has a fully async API, so same story.

Plus, we already have some places where we for example start a number of parallel downloads via async, but those things could presumably also be simplified if we had a proper async runtime.

@IanButterworth
Copy link
Member Author

Merge?

@davidanthoff davidanthoff merged commit 980e43d into main Nov 23, 2024
25 checks passed
@IanButterworth
Copy link
Member Author

Bump for having this released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants