-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function setladj #22
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 5 +2
Lines 61 82 +21
=========================================
+ Hits 61 82 +21
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor comments.
Thanks for the doc fixes @devmotion ! |
Co-authored-by: David Widmann <[email protected]>
I think we're good now. |
@devmotion, this PR mirrors
InverseFunctions.setinverse
.With this, we can do stuff like
I have several used cases that would profit from such "on-the-fly" adding of LADJ-computation (intermediate steps in transforming flows, etc). It's also very handy for demos and tutorials.
This PR also adds
with_logabsdet_jacobian
support forInverseFunctions.FunctionWithInverse
.CC @cscherrer