Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Aqua.test_all(FixedPointDecimal) pass #104

Merged
merged 13 commits into from
Jan 23, 2025

Conversation

kuszmaul
Copy link
Contributor

@kuszmaul kuszmaul commented Jan 23, 2025

Make Aqua.test_all(FixedPointDecimal) pass.

Increment the patch level.

Add compat values for the extras in Project.toml

Import Base symbols that are reexported.

Define and test extra methods to disambiguate.

@kuszmaul kuszmaul marked this pull request as draft January 23, 2025 00:28
Copy link
Collaborator

@nickrobinson251 nickrobinson251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add Aqua.test_all(FixedPointDecimal) as a test in this repo?

Project.toml Outdated Show resolved Hide resolved
Co-authored-by: Nick Robinson <[email protected]>
@kuszmaul kuszmaul marked this pull request as ready for review January 23, 2025 13:44
@kuszmaul
Copy link
Contributor Author

Shall we add Aqua.test_all(FixedPointDecimal) as a test in this repo?

I'll do that

@kuszmaul
Copy link
Contributor Author

I added Aqua tests and also unit tests for the newly-defined methods. I think this is ready to merge. I don't have write access to this repo.

@kuszmaul kuszmaul changed the title Bck aqua clean Make Aqua.test_all(FixedPointDecimal) pass Jan 23, 2025
@kuszmaul kuszmaul marked this pull request as draft January 23, 2025 14:59
@kuszmaul
Copy link
Contributor Author

The aqua tests aren't runnign. Needs another fix.

test/aqua_test.jl Outdated Show resolved Hide resolved
test/aqua_test.jl Show resolved Hide resolved
@kuszmaul kuszmaul marked this pull request as ready for review January 23, 2025 15:36
@nickrobinson251
Copy link
Collaborator

test failures of nightly julia look related to JuliaLang/julia#57064

@nickrobinson251 nickrobinson251 merged commit 20c21c5 into JuliaMath:master Jan 23, 2025
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants