Add stack markings for GNU to fmod assembly files #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds stack markings to the missing fmod .S files, otherwise the final libopenlibm object file gets marked with an executable stack. Output when compiling from source on Gentoo Linux: ``` * QA Notice: The following files contain writable and executable sections * Files with such sections will not work properly (or at all!) on some * architectures/operating systems. A bug should be filed at * https://bugs.gentoo.org/ to make sure the issue is fixed. * For more information, see: * * https://wiki.gentoo.org/wiki/Hardened/GNU_stack_quickstart * * Please include the following list of files in your report: * Note: Bugs should be filed for the respective maintainers * of the package in question and not [email protected]. * RWX --- --- usr/lib64/libopenlibm.so.4.0 ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #307 +/- ##
=======================================
Coverage 39.02% 39.02%
=======================================
Files 233 233
Lines 6144 6144
Branches 1608 1607 -1
=======================================
Hits 2398 2398
Misses 3393 3393
Partials 353 353 ☔ View full report in Codecov by Sentry. |
Keno
approved these changes
Aug 4, 2024
|
Thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds stack markings to the missing fmod .S files, otherwise the final libopenlibm object file gets marked with an executable stack.
Output when compiling from source on Gentoo Linux: