LsqFit 0.13.1 #244
Merged
LsqFit 0.13.1 #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/JuliaNLSolvers/LsqFit.jl/blob/85d2165fb50c1563b911cd5391df38f9f0f1abd7/test/curve_fit.jl#L62C1-L63C1 I'm curious why the tests fail with diagm of a matrix here. Locally it's a vector when I try to run it |
|
I see it's for Julia v1.1 only. The other error is one @ararslan talked about previously, but maybe we just need to add |
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
=========================================
Coverage ? 90.34%
=========================================
Files ? 4
Lines ? 259
Branches ? 0
=========================================
Hits ? 234
Misses ? 25
Partials ? 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #243
Given that #243 is lingering, if @pkofod doesn't respond promptly, is there anyone else in this org (Patrick is the only public member) that could make a call on this?