Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Compat Bounds for NNlib #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacobadenbaum
Copy link

I've updated the compat bounds for NNlib to allow v0.9

I've also fixed an issue with the GPU tests where the test environment was erroring because it required an old version of CUDA and NNlibCUDA (which has been deprecated in favor of a CUDA extension in NNlib).

Please note: I have not been able to verify that the GPU tests run, since I do not have access to CUDA on my development machine.

- changed compat bounds
- fixed broken environment for GPU tests
@jacobadenbaum
Copy link
Author

I'll note: although it looks like the CI tests for this are failing, I don't think that has anything to do with this PR. It would be great if a maintainer could look at the CI setup for this to figure out what the problem is, since its not something that I think I can resolve here

Copy link
Member

@davibarreira davibarreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devmotion and @zsteve , this PR is just updating the version. I haven't worked on GPU stuff, so I haven't figured out why the error in the testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants