Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logging instead of print #234

Merged
merged 4 commits into from
Feb 18, 2019
Merged

Use logging instead of print #234

merged 4 commits into from
Feb 18, 2019

Conversation

tkf
Copy link
Member

@tkf tkf commented Feb 17, 2019

A small step toward #199.

@coveralls
Copy link

coveralls commented Feb 17, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 543

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 75.0%
Totals Coverage Status
Change from base Build 541: -0.09%
Covered Lines: 603
Relevant Lines: 804
💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 543

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 75.0%
Totals Coverage Status
Change from base Build 541: -0.09%
Covered Lines: 603
Relevant Lines: 804
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 543

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 75.0%
Totals Coverage Status
Change from base Build 541: -0.09%
Covered Lines: 603
Relevant Lines: 804
💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 17, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 545

  • 33 of 33 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 75.368%
Totals Coverage Status
Change from base Build 541: 0.3%
Covered Lines: 615
Relevant Lines: 816
💛 - Coveralls

tkf added 2 commits February 16, 2019 17:06
@tkf
Pass -s (turn off capture) to pytest in CI
6de2b31 
This is required for getting the same verbose debug output as before.
@tkf
Do not invoke logging.basicConfig via debug=True
7ec1e45
@tkf tkf merged commit 7ec1e45 into JuliaPy:master Feb 18, 2019
@tkf tkf deleted the logging branch February 18, 2019 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkf @coveralls