Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest plugin mechanism to conditionally skip tests requiring Julia runtime #237

Merged
merged 7 commits into from
Mar 12, 2019

Conversation

tkf
Copy link
Member

@tkf tkf commented Feb 18, 2019

This PR adds pytest plugin to provide:

  • julia fixture which automate initializing Julia runtime used for tests.

  • Tests using julia fixture or other fixtures which in turn depend on julia fixture can be skipped with --no-julia CLI option.

This plugin can be used not only for PyJulia's test suite but also for any downstream projects.

TODO:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 569

  • 123 of 149 (82.55%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 75.515%

Changes Missing Coverage Covered Lines Changed/Added Lines %
julia/with_rebuilt.py 1 4 25.0%
julia/pytestplugin.py 4 12 33.33%
julia/core.py 117 132 88.64%
Files with Coverage Reduction New Missed Lines %
julia/core.py 7 83.05%
Totals Coverage Status
Change from base Build 546: 0.1%
Covered Lines: 660
Relevant Lines: 874

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 11, 2019

Pull Request Test Coverage Report for Build 572

  • 123 of 149 (82.55%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 75.515%

Changes Missing Coverage Covered Lines Changed/Added Lines %
julia/with_rebuilt.py 1 4 25.0%
julia/pytestplugin.py 4 12 33.33%
julia/core.py 117 132 88.64%
Files with Coverage Reduction New Missed Lines %
julia/core.py 7 83.05%
Totals Coverage Status
Change from base Build 546: 0.1%
Covered Lines: 660
Relevant Lines: 874

💛 - Coveralls

This is required for `--no-julia` to work.
@tkf tkf merged commit e574f05 into JuliaPy:master Mar 12, 2019
@tkf tkf deleted the test branch March 23, 2019 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants