Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge code for overapproximate of TaylorModelReachSet #766

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

schillic
Copy link
Member

@schillic schillic commented Jan 24, 2024

  1. The methods
function _overapproximate(R::TaylorModelReachSet{N}, ::Type{<:Hyperrectangle};
                          Δt::TimeInterval=tspan(R), dom=symBox(dim(R))) where {N}
function _overapproximate(R::TaylorModelReachSet{N}, ::Type{<:Zonotope};
                          Δt::TimeInterval=tspan(R), dom=symBox(dim(R))) where {N}

only differed in the last line (modulo reordering of other lines).

  1. The method
function overapproximate(R::TaylorModelReachSet{N}, ::Type{<:Zonotope}, t::AbstractFloat;
                         remove_zero_generators=true) where {N}

was almost identical too; now it calls the common method above instead. Furthermore, a method for time points and Hyperrectangle was not available; now it is.

  1. I added a TODO to outsource some code to LazySets. I already added a PR for that here:
    Box approximation of a Taylor model LazySets.jl#3432

@schillic schillic force-pushed the schillic/oa_TM branch 7 times, most recently from bc0e41e to b3ed3f9 Compare January 25, 2024 15:00
@schillic schillic marked this pull request as ready for review January 25, 2024 22:14
@schillic schillic merged commit fb9601b into master Jan 31, 2024
6 checks passed
@schillic schillic deleted the schillic/oa_TM branch January 31, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants