setPointsMani! of array from point #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
- Coverage 55.24% 54.99% -0.25%
==========================================
Files 17 17
Lines 887 891 +4
==========================================
Hits 490 490
- Misses 397 401 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dehann
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetPointsMani!really needs to be refactored.Perhaps the design should be: always have a vector of points on a manifold and replace the entire point.
The issue with that will be if the points can no longer efficiently be represented by bits types.