Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Line Search with Negative Curvature Detection for MINRES Based on Liu et al. (2022) #969

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/block_krylov_solvers.jl
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
Hₖ₋₁ = SM(undef, 2p, p)
τₖ₋₂ = SV(undef, p)
τₖ₋₁ = SV(undef, p)
stats = SimpleStats(0, false, false, T[], T[], T[], 0.0, "unknown")
stats = SimpleStats(0, false, false, false, T[], T[], T[], 0.0, "unknown")

Check warning on line 63 in src/block_krylov_solvers.jl

View check run for this annotation

Codecov / codecov/patch

src/block_krylov_solvers.jl#L63

Added line #L63 was not covered by tests
solver = BlockMinresSolver{T,FC,SV,SM}(m, n, p, ΔX, X, P, Q, C, D, Φ, Vₖ₋₁, Vₖ, wₖ₋₂, wₖ₋₁, Hₖ₋₂, Hₖ₋₁, τₖ₋₂, τₖ₋₁, false, stats)
return solver
end
Expand Down Expand Up @@ -121,7 +121,7 @@
R = SM[SM(undef, p, p) for i = 1 : div(memory * (memory+1), 2)]
H = SM[SM(undef, 2p, p) for i = 1 : memory]
τ = SV[SV(undef, p) for i = 1 : memory]
stats = SimpleStats(0, false, false, T[], T[], T[], 0.0, "unknown")
stats = SimpleStats(0, false, false, false, T[], T[], T[], 0.0, "unknown")

Check warning on line 124 in src/block_krylov_solvers.jl

View check run for this annotation

Codecov / codecov/patch

src/block_krylov_solvers.jl#L124

Added line #L124 was not covered by tests
solver = BlockGmresSolver{T,FC,SV,SM}(m, n, p, ΔX, X, W, P, Q, C, D, V, Z, R, H, τ, false, stats)
return solver
end
Expand Down
Loading
Loading