-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plot recipes #582
base: master
Are you sure you want to change the base?
Plot recipes #582
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #582 +/- ##
==========================================
- Coverage 90.33% 85.96% -4.37%
==========================================
Files 8 11 +3
Lines 1107 1297 +190
==========================================
+ Hits 1000 1115 +115
- Misses 107 182 +75 ☔ View full report in Codecov by Sentry. |
@ajinkya-k @andreasnoack It would be good to get some feedback about this PR. I finally got time to write some tests, but ultimately plot recipes are hard to test beyond "does not catastrophically crash", and I'm not sure that I can test both the StatsPlots and Makie Recipes since they override the same function. One option would be to put the recipes into separate mini packages rather than extensions. |
This PR builds on the discussion in #581 and provides summary plots of
LinearModel
s for both Plots and Makie. The plots are based on those from R'splot.lm
function. While one new lightweight dependency is needed forRecipesBase
, the plots are implemented as extensions forStatsPlots
andMakie
.Implemented features
lmplot
displaying the residual plot, Q-Q plot, scale-location plot and residuals-leverage plot. The configurability of this function is limited, however.lm.jl
.StatsPlots
extension, default values for the axis labels and title are provided. This is not available for the Makie extension, except inlmplot
.Not implemented
docs/
. This seems like a good thing to add.Examples
StatsPlots:
Makie:
R equivalent:
