-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strip trailing dots in goto/datatip (and rename) #208
Conversation
38c48b3
to
e01169a
Compare
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 40.03% 40.22% +0.19%
==========================================
Files 40 40
Lines 1856 1857 +1
==========================================
+ Hits 743 747 +4
+ Misses 1113 1110 -3
Continue to review full report at Codecov.
|
35d8f31
to
9759a5a
Compare
@pfitzseb any objection on this idea ? I will make changes so that the striping would be done in the frontend, though. |
Makes sense to me, I think. Might be somewhat unintuitive, but we can probably add some clarity by highlighting the part we're using (if that makes sense). |
e43804d
to
5d8b703
Compare
okay, so the striping task is now all done in the frontend (basically by using different regex for the beginning and end of the word), and the awkward
yes, maybe especially when we get goto/datatip for Still I'm not sure which behaviour do people prefer (not so many of users mayn't even care about the difference tho) |
5d8b703
to
7ef71d7
Compare
The last two commits refactor the logic in Once the CI passes, I will merge this PR, since now trailing dots are stripped all in the frontend (JunoLab/atom-julia-client#651) and the changes in this PR only do the trivial refactors. If we find the stripping trailing dots really unintuitive, we can discard/revert JunoLab/atom-julia-client#651, but the changes in this PR wouldn't get affected by that at all. |
While implementing #203, I had to implement the logic to remove trailing dots and found that this is better to be merged as a separate feature, since the logic can be used for goto/datatip.
In short, if we have a word like
and then, we can get goto and datatip for:
Atom
when our cursor is anywhere onAtom
Atom.SYMBOLSCACHE
when our cursor is anywhere onSYMBOLSCACHE
age
(the field)(c.f.: The current behaviour: we can't get any goto and datatip at all)
Requires JunoLab/atom-julia-client#651