validate repository object outside converter

JupiterOne-Archives · Jul 15, 2024 · 827f1e8 · 827f1e8
1 parent 50b68a7
commit 827f1e8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/src/steps/secretScanningAlerts.ts b/src/steps/secretScanningAlerts.ts
@@ -28,19 +28,15 @@ export async function fetchSecretScanningAlerts({
   const restClient = getOrCreateRestClient(config, logger);
 
   await restClient.iterateSecretScanningAlerts(async (alert) => {
-    const secretScanningAlertEntity = createSecretScanningAlertEntity(
-      alert,
-    ) as SecretScanningFindingEntity;
-    if (!secretScanningAlertEntity) {
+    if (!alert.repository?.node_id) {
       return;
     }
-    await jobState.addEntity(secretScanningAlertEntity);
+    const secretScanningAlertEntity = await jobState.addEntity(
+      createSecretScanningAlertEntity(alert) as SecretScanningFindingEntity,
+    );
 
-    const repoEntityKey =
-      alert.repository?.node_id &&
-      getRepositoryEntityKey(alert.repository.node_id);
-
-    if (repoEntityKey && jobState.hasKey(repoEntityKey)) {
+    const repoEntityKey = getRepositoryEntityKey(alert.repository.node_id);
+    if (jobState.hasKey(repoEntityKey)) {
       await jobState.addRelationship(
         createDirectRelationship({
           _class: RelationshipClass.HAS,

diff --git a/src/sync/converters.ts b/src/sync/converters.ts
@@ -204,9 +204,6 @@ export function getSecretScanningAlertKey(
 export function createSecretScanningAlertEntity(
   data: SecretScanningAlertQueryResponse,
 ) {
-  if (!data.repository) {
-    return;
-  }
   return createIntegrationEntity({
     entityData: {
       source: data,