-
Notifications
You must be signed in to change notification settings - Fork 13
INT-5712 Add job logs for steps that will be skipped due to disabled services #558
base: main
Are you sure you want to change the base?
Conversation
…services We will now print out a job log for all of the disabled google-cloud services in the customer's account, and the graph steps that will be skipped as a result. To do this, the interface for createStepStartState has been updated to include the stepId. A map of disabled services to steps has been added to track which services are disabled and the steps that will subsequently be disabled as well as we cerate each step start state.
Ok this is going to look like a lot of changes, but really just the |
…SHIPS step that was removed during merge to main
export function getDisabledServiceToStepMap() { | ||
return disabledServiceToStepMap; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to make this a pure function? As a general rule, I try to avoid writing any stateful functions because they tend to be difficult to test/debug and can cause strange side-effects.
I think this one has been superceded by #574. Can you see if this is still necessary, and close if not? |
We will now print out a job log for all of the disabled google-cloud services
in the customer's account, and the graph steps that will be skipped as a result.
To do this, the interface for createStepStartState has been updated to include
the stepId. A map of disabled services to steps has been added to track which
services are disabled and the steps that will subsequently be disabled as well
as we cerate each step start state.