Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

INT-5712 Add job logs for steps that will be skipped due to disabled services #558

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JakeFerrero
Copy link
Contributor

We will now print out a job log for all of the disabled google-cloud services
in the customer's account, and the graph steps that will be skipped as a result.
To do this, the interface for createStepStartState has been updated to include
the stepId. A map of disabled services to steps has been added to track which
services are disabled and the steps that will subsequently be disabled as well
as we cerate each step start state.

Jake Ferrero added 2 commits November 15, 2022 11:46
…services

We will now print out a job log for all of the disabled google-cloud services
in the customer's account, and the graph steps that will be skipped as a result.
To do this, the interface for createStepStartState has been updated to include
the stepId. A map of disabled services to steps has been added to track which
services are disabled and the steps that will subsequently be disabled as well
as we cerate each step start state.
@JakeFerrero JakeFerrero requested a review from a team as a code owner November 15, 2022 16:50
@JakeFerrero
Copy link
Contributor Author

Ok this is going to look like a lot of changes, but really just the createStepStartState function params were updated. However, every step calls this function, so there needed to be a change per step. But the change is just updating what we're passing to the createStepStartState. I'd definitely appreciate if someone could take on the arduous task of going through each call and ensuring the step ID's match. I will say though, even if we somehow miss one, the only thing that will be incorrect is the log statement.

@JakeFerrero
Copy link
Contributor Author

This is what the job logs look like:
Screen Shot 2022-11-16 at 11 13 19

Comment on lines +10 to +12
export function getDisabledServiceToStepMap() {
return disabledServiceToStepMap;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to make this a pure function? As a general rule, I try to avoid writing any stateful functions because they tend to be difficult to test/debug and can cause strange side-effects.

@JakeFerrero JakeFerrero marked this pull request as draft November 29, 2022 16:36
@ndowmon
Copy link
Contributor

ndowmon commented Apr 19, 2023

I think this one has been superceded by #574. Can you see if this is still necessary, and close if not?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants