This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
Make servicenow faster - more resilient #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,20 +122,6 @@ export class ServiceNowClient { | |||
| const response = await this.request({ url }); | |||
| const result = response?.data?.result; | |||
|
|
|||
| const redactedResponse = { | |||
There was a problem hiding this comment.
Removed log
| for (const r of paginatedResponse.result) { | ||
| await callback(r); | ||
| } | ||
|
|
There was a problem hiding this comment.
Removed log
| @@ -13,10 +13,6 @@ export const Steps = { | |||
| GROUP_MEMBERS: 'step-group-members', | |||
| INCIDENTS: 'step-incidents', | |||
| CMDB: 'step-cmdb', | |||
| USER_OWNS_CMDB: 'step_user_owns_cmdb', | |||
There was a problem hiding this comment.
Merged this 4 steps into the cmdb step to make the whole process faster
| @@ -35,113 +35,80 @@ export async function fetchCMDB( | |||
|
|
|||
| await client.iterateTableResources({ | |||
| table: parent, | |||
| limit: 3_000, | |||
There was a problem hiding this comment.
Default for table api is 10_000 so the api is really good at handling large amounts of data. I bumped by x6 to be careful with our memory usage
src/steps/converters.ts
Outdated
| @@ -106,7 +107,7 @@ export function createIncidentAssigneeRelationship( | |||
| fromType: Entities.INCIDENT._type, | |||
| fromKey: incident.sys_id, | |||
| toType: Entities.USER._type, | |||
| toKey: incident.assigned_to.value, | |||
| toKey: incident.assigned_to?.value, | |||
There was a problem hiding this comment.
Doesn't the toKey need to always be present?
There was a problem hiding this comment.
Good call, I'll remove the optional chaining there
RonaldEAM
approved these changes
Jun 18, 2024
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thank you for contributing to a JupiterOne integration!
Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.
Summary
Type of change
Please leave any irrelevant options unchecked.
not work as expected)
Checklist
General Development Checklist:
Integration Development Checklist:
Please leave any irrelevant options unchecked.
endpoints, and have documented any additional permissions in
jupiterone.md, where necessary.API
using
dependsOnJupiterOne data model
to ensure that any new entities/relationships, and relevant properties,
match the recommended model for this class of data
CHANGELOG.mdfile to describe my changesreviewed all existing managed questions referencing the entities,
relationships, and their property names, to ensure those questions still
function with my changes.