This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
Fix CMDB Converter #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Eliminates double quotes from being included as part of the value.
VDubber
commented
Jun 26, 2024
|
|
||
| let finalValue = value; | ||
| if (typeof value == 'object') { | ||
| // Only stringify if value is an object to avoid double quotes around primitive values. |
There was a problem hiding this comment.
I believe that this condition is correct but maybe be overly simplistic.
There was a problem hiding this comment.
Arrays will be stringified
Gonzalo-Avalos-Ribas
approved these changes
Jun 26, 2024
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property values such as
""and"test"were found in the graph data. This PR changes so that only objects will be stringified.