This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
INT-2714 - Fix for hardware mapping #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXtremeX
force-pushed
the
bugfix/hardware-mapping
branch
from
270ed0c to
d0cce29
Compare
VDubber
reviewed
Jan 26, 2023
| @@ -75,10 +90,12 @@ export function mapHardwareRelationship( | |||
| sourceEntityKey: account._key, | |||
| targetFilterKeys: [['_class', filterKey]], | |||
| targetEntity: { | |||
| ...convertProperties(hardware), | |||
There was a problem hiding this comment.
We need to verify that the properties that were being produce here are not being used by customers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Snipe-IT allows us to use particular host name that's filled with sample data (https://develop.snipeitapp.com). Once we used that we noticed that not all hardware responses contain the values we had assigned to
manufacturer,makeand/ormodel. The integration was erroring out for those.We also noticed that
convertHardwarefunction isn't able to return macAddress nor hardwareId so we deleted those two branches.unknownvalue if hardwaremanufacturer,makeormodelfieldis undefined.
only access the
serialvalue).