SRE-1782 #166
Merged
SRE-1782 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
client_payloadinput that is passed along as a part of thetrigger-workflow-and-waitaction uses the PR title as a parameter without escaping it. If the title has double quotes (ex."SRE-1782 - Test PR title with "double quotes""), it will cause the json to be invalid and cause tests to fail. To address this, we simply need to wrap the parameter in atoJSONexpression which will escape the quotes as shown here:Testing
This was tested in
web-dashboardsusing local actions.