Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kno 358 #110

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Kno 358 #110

wants to merge 6 commits into from

Conversation

mikiodehartj1
Copy link
Contributor

QA Checklist

Alerts Rule Packs

  • IF THIS CONTENT NEEDS TO BE RELEASED - is the package version in the package.json bumped?
  • Does a related alert already exist, and should it be tweaked or added to instead?
  • Test each query to make sure it works
  • Look for hardcoded variables/parameter values in the query
  • Consider Severity for Alerts
  • Spellcheck
  • Use all caps for J1QL keywords and relationship classes
  • Upload the alerts rule pack JSON into JupiterOne to validate

@mikiodehartj1 mikiodehartj1 requested a review from a team as a code owner April 10, 2024 20:38
SeaBlooms
SeaBlooms previously approved these changes Apr 11, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaBlooms SeaBlooms SeaBlooms left review comments

@jzolo22 jzolo22 Awaiting requested review from jzolo22

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikiodehartj1 @SeaBlooms @jzolo22