Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Commit

Permalink
.NET 8
Browse files Browse the repository at this point in the history
  • Loading branch information
JustArchi committed Nov 14, 2023
1 parent cf31030 commit cd3f95d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on: [push, pull_request]
env:
DOTNET_CLI_TELEMETRY_OPTOUT: true
DOTNET_NOLOGO: true
DOTNET_SDK_VERSION: 7.0.x
DOTNET_SDK_VERSION: 8.0

jobs:
main:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ env:
CONFIGURATION: Release
DOTNET_CLI_TELEMETRY_OPTOUT: true
DOTNET_NOLOGO: true
DOTNET_SDK_VERSION: 7.0.x
DOTNET_SDK_VERSION: 8.0

jobs:
publish:
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ We support `netstandard2.0`, so .NET Framework 4.6.1 and newer. There is also a
dotnet add package JustArchiNET.Madness
```

If you're targetting multiple frameworks out of which only one is .NET Framework (e.g. `net7.0` and `net481`), it's *usually* a good idea to not pull it for the others.
If you're targetting multiple frameworks out of which only one is .NET Framework (e.g. `net8.0` and `net481`), it's *usually* a good idea to not pull it for the others.

```csproj
<ItemGroup Condition="'$(TargetFramework)' == 'net481'">
Expand Down Expand Up @@ -270,7 +270,7 @@ namespace ThisIsMadness {

If you're building only for .NET Framework exclusively, no, it's not required and actually quite useless code verbosity for you.

However, if you're targetting multiple frameworks out of which only one is .NET Framework (e.g. `net7.0` and `net481`), then `#if` clause guarantees that madness won't embrace your other targets.
However, if you're targetting multiple frameworks out of which only one is .NET Framework (e.g. `net8.0` and `net481`), then `#if` clause guarantees that madness won't embrace your other targets.

You don't want madness to embrace your other targets, do you?

Expand Down

0 comments on commit cd3f95d

Please sign in to comment.