Skip to content

Commit

Permalink
1.4.5
Browse files Browse the repository at this point in the history
  • Loading branch information
dmitrii-fediuk committed Nov 23, 2020
1 parent 5656af4 commit b2ef83b
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
6 changes: 5 additions & 1 deletion Controller/Response/Catalog.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class Catalog extends _P {
* @return Json
*/
function execute() {return R::p(function() {
$pc = ju_product_c(); /** @var PC $pc */
$pc = ju_pc(); /** @var PC $pc */
$pc->addAttributeToSelect('*');
/**
* 2019-10-30
Expand All @@ -40,6 +40,10 @@ function execute() {return R::p(function() {
$pc->addAttributeToFilter('visibility', ['in' => [
V::VISIBILITY_BOTH, V::VISIBILITY_IN_CATALOG, V::VISIBILITY_IN_SEARCH
]]);
# 2020-11-23
# @todo If the flat mode is enabled, then at this point the collection already misses diabled products,
# because the `catalog_product_flat_<store>` table does not contain disabled products at least in Magento 2.4.0.
# It is wrong because disabled products should be in the feed: https://github.com/justuno-com/m2/issues/19
/**
* 2019-11-22
* @uses \Magento\Catalog\Model\ResourceModel\Product\Collection::addMediaGalleryData() loads the collection,
Expand Down
2 changes: 1 addition & 1 deletion Controller/Response/Inventory.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ function(P $p) {return ['ID' => $p->getId(), 'Variants' => cVariants::p($p)];}
* 2) @uses \Magento\Catalog\Model\ResourceModel\Product\Collection::setVisibility()
* filters out the disabled products.
*/
,ju_product_c()->setVisibility([V::VISIBILITY_BOTH, V::VISIBILITY_IN_CATALOG, V::VISIBILITY_IN_SEARCH])
,ju_pc()->setVisibility([V::VISIBILITY_BOTH, V::VISIBILITY_IN_CATALOG, V::VISIBILITY_IN_SEARCH])
));}, true);}
}
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "justuno.com/m2"
,"version": "1.4.4"
,"version": "1.4.5"
,"description": "Justuno module for Magento 2"
,"type": "magento2-module"
,"homepage": "https://github.com/justuno-com/m2"
Expand All @@ -11,7 +11,7 @@
,"homepage": "https://mage2.pro/users/dmitry_fedyuk"
,"role": "Developer"
}]
,"require": {"justuno.com/core": ">=1.0.1"}
,"require": {"justuno.com/core": ">=1.0.2"}
,"autoload": {"files": ["registration.php"], "psr-4": {"Justuno\\M2\\": ""}}
,"keywords": ["Magento 2"]
}

0 comments on commit b2ef83b

Please sign in to comment.