Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: add option to display 1.0M as 1000K #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

S0yKaf
Copy link

@S0yKaf S0yKaf commented Sep 2, 2024

This is a change to implement #56

I cleaned up the code a bit in the truncateText function.
I also changed the behavior of truncateLetter to be the toggle for the Million display as 1.0M versus 1000K.

in short:

  • Truncate Letter -> 1.0M
  • Truncate Letter -> 1000K

@nanjuekaien1
Copy link
Contributor

nanjuekaien1 commented Sep 8, 2024

@S0yKaf
Why cleaned up L[‘Truncate Letter East Asia’] support for East Asia?

@S0yKaf
Copy link
Author

S0yKaf commented Sep 8, 2024

@S0yKaf
Why cleaned up L[‘Truncate Letter East Asia’] support for East Asia?

I just cleaned up the code to be more readable and less redundant. I did not change the functionality.

If the functionality did change, It wasn't my intention. so please let me know if that's the case.

@nanjuekaien1
Copy link
Contributor

@S0yKaf
L['Truncate Letter East Asia'] It was added for the localisation of East Asia, which translates to ‘M’ = ‘万’.

@S0yKaf
Copy link
Author

S0yKaf commented Sep 10, 2024

@nanjuekaien1 I understand what I did wrong now. I fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants