Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tippy-component): use Element constructor for to prop #311

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

J-Michalek
Copy link

Using Element as the prop constructor should work just fine. The usage of Function constructor also causes Vue warnings, when an Element is provided as the value.

This way there is no longer need to cast the prop using PropType<string | Element>.

@KABBOUCHI
Copy link
Owner

KABBOUCHI commented May 27, 2024

@J-Michalek if remember correctly, using Element as value caused SSR issues in Nuxt few years back, I need to test it properly with Nuxt first.

@J-Michalek
Copy link
Author

Well if it is still an issue today, may I suggest adding a comment to the prop so that it is obvious that it should indeed be that way? I am not using Nuxt, so I cannot easily help with testing it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants