chore: Rename PinButton to MovedToSideBar

As the dock widget can move to sidebar programatically too, without any pin button involved
KDAB · Apr 2, 2024 · 0305548 · 0305548
1 parent 84928bb
commit 0305548
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/KDDockWidgets.h b/src/KDDockWidgets.h
@@ -378,7 +378,7 @@ enum class CloseReason {
     Unspecified = 0, /// probably programmatically
     TitleBarCloseButton = 1, /// User clicked titlebar close button
     Action = 2, /// User clicked menu with QAction
-    PinButton = 4, /// User clicked the pin-button (auto-hide/sidebar/pin-unpin functionallity)
+    MovedToSideBar = 4, /// User clicked the pin-button (or programatically) (auto-hide/sidebar/pin-unpin functionallity)
     OverlayCollapse = 8 /// Dock widget went from overlay to sidebar (auto-hide/sidebar/pin-unpin functionallity)
 };
 

diff --git a/src/core/MainWindow.cpp b/src/core/MainWindow.cpp
@@ -529,7 +529,7 @@ void MainWindow::moveToSideBar(Core::DockWidget *dw, SideBarLocation location)
 
     if (Core::SideBar *sb = sideBar(location)) {
         ScopedValueRollback rollback(dw->d->m_isMovingToSideBar, true);
-        CloseReasonSetter reason(CloseReason::PinButton);
+        CloseReasonSetter reason(CloseReason::MovedToSideBar);
         dw->forceClose();
         sb->addDockWidget(dw);
     } else {

diff --git a/src/core/TitleBar.cpp b/src/core/TitleBar.cpp
@@ -559,7 +559,7 @@ void TitleBar::onAutoHideClicked()
             registry->addSideBarGrouping(dockwidgets);
 
 
-        CloseReasonSetter reason(CloseReason::PinButton);
+        CloseReasonSetter reason(CloseReason::MovedToSideBar);
         for (DockWidget *dw : dockwidgets) {
             if (groupedAutoHide || dw == currentDw)
                 dw->moveToSideBar();

diff --git a/tests/qtwidgets/tst_qtwidgets.cpp b/tests/qtwidgets/tst_qtwidgets.cpp
@@ -1212,7 +1212,7 @@ void TestQtWidgets::tst_sidebarCloseReason()
                 Q_ASSERT(dw1->lastCloseReason() == expectedLastReason);
         });
 
-        expectedLastReason = CloseReason::PinButton;
+        expectedLastReason = CloseReason::MovedToSideBar;
         dw1->titleBar()->onAutoHideClicked();
         QVERIFY(dw1->isInSideBar());
         QVERIFY(!dw1->isOpen());
@@ -1234,7 +1234,7 @@ void TestQtWidgets::tst_sidebarCloseReason()
         dw1->titleBar()->onCloseClicked();
         QCOMPARE(dw1->lastCloseReason(), expectedLastReason);
 
-        expectedLastReason = CloseReason::PinButton;
+        expectedLastReason = CloseReason::MovedToSideBar;
         dw1->open();
         m1->moveToSideBar(dw1);
         QCOMPARE(dw1->lastCloseReason(), expectedLastReason);