chore: Rename CloseReason::TitleBarButton

To CloseReason::TitleBarCloseButton, as there's other buttons capable of closing the dock widget (like the pin button)
KDAB · Apr 2, 2024 · fba7cb4 · fba7cb4
1 parent 82136f5
commit fba7cb4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/KDDockWidgets.h b/src/KDDockWidgets.h
@@ -376,8 +376,8 @@ Q_DECLARE_FLAGS(WindowStates, WindowState)
 /// @internal
 enum class CloseReason {
     Unspecified = 0, /// probably programmatically
-    TitleBarButton = 1, /// User clicked titlebar close button
-    Action = 2 /// User clicked menu with QAction
+    TitleBarCloseButton = 1, /// User clicked titlebar close button
+    Action = 2, /// User clicked menu with QAction
 };
 
 /// @brief Initializes the desired frontend

diff --git a/src/core/TitleBar.cpp b/src/core/TitleBar.cpp
@@ -402,7 +402,7 @@ void TitleBar::setIcon(const Icon &icon)
 
 void TitleBar::onCloseClicked()
 {
-    CloseReasonSetter reason(CloseReason::TitleBarButton);
+    CloseReasonSetter reason(CloseReason::TitleBarCloseButton);
 
     const bool closeOnlyCurrentTab = Config::self().flags() & Config::Flag_CloseOnlyCurrentTab;
 

diff --git a/tests/tst_docks.cpp b/tests/tst_docks.cpp
@@ -841,7 +841,7 @@ KDDW_QCORO_TASK tst_closeReason()
         // TitleBar close
         dock1->titleBar()->onCloseClicked();
         CHECK(!dock1->isOpen());
-        CHECK_EQ(dock1->lastCloseReason(), CloseReason::TitleBarButton);
+        CHECK_EQ(dock1->lastCloseReason(), CloseReason::TitleBarCloseButton);
 
         // Programmatic close
         dock1->open();