Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolves #7] 예외 처리 구현 #9

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ dependencies {
implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
implementation 'org.springframework.boot:spring-boot-starter-validation'
implementation 'org.springframework.boot:spring-boot-starter-web'
implementation 'org.springframework.boot:spring-boot-starter-data-redis'
compileOnly 'org.projectlombok:lombok'
runtimeOnly 'com.h2database:h2'
runtimeOnly 'mysql:mysql-connector-java'
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/oncoding/concoder/ConcoderApplication.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.data.jpa.repository.config.EnableJpaAuditing;

@EnableJpaAuditing
@SpringBootApplication
public class ConcoderApplication {

Expand Down
62 changes: 62 additions & 0 deletions src/main/java/oncoding/concoder/config/RedisConfig.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
package oncoding.concoder.config;

import org.springframework.beans.factory.annotation.Value;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.data.redis.connection.lettuce.LettuceConnection;
import org.springframework.data.redis.connection.lettuce.LettuceConnectionFactory;
import org.springframework.data.redis.core.RedisTemplate;
import org.springframework.data.redis.core.StringRedisTemplate;
import org.springframework.data.redis.serializer.StringRedisSerializer;

@Configuration
public class RedisConfig {

@Value("${spring.redis.host}")
private String host;

@Value("${spring.redis.port}")
private int port;

/*
Spring Data Redis는 Redis에 두 가지 접근 방식을 제공합니다.
하나는 RedisTemplate을 이용한 방식이며, 다른 하나는 RedisRepository를 이용한 방식

두 방식 모두 Redis에 접근하기 위해서는 Redis 저장소와 연결하는 과정이 필요
이 과정을 위해 RedisConnectionFactory 인터페이스(LettuceConnectionFactory )를 사용
* */
@Bean //redisConnectionFactory 이름의 빈(역할)은 LettuceConnectionFactory(host, port)를 구현체로 선택한 것
public LettuceConnectionFactory redisConnectionFactory() {
return new LettuceConnectionFactory(host, port);
}

/*
redisTemplate을 사용하여 Redis 저장소에 접근하기로 한다
RedisTemplate은 Redis 저장소에 오브젝트를 저장할 때 기본값으로 정의된 JdkSerializationRedisSerializer을 이용
*/
@Bean
public RedisTemplate<String,Object> redisTemplate(){
RedisTemplate<String,Object> redisTemplate = new RedisTemplate<>();
redisTemplate.setKeySerializer(new StringRedisSerializer());
redisTemplate.setValueSerializer(new StringRedisSerializer());
redisTemplate.setConnectionFactory(redisConnectionFactory());
return redisTemplate;
}

/*
대부분 레디스 key-value 는 문자열 위주이기 때문에 문자열에 특화된 템플릿을 제공
RedisTemplate 을 상속받은 클래스임.
StringRedisSerializer로 직렬화함
*/
@Bean
public StringRedisTemplate stringRedisTemplate(){
final StringRedisTemplate stringRedisTemplate = new StringRedisTemplate();
stringRedisTemplate.setKeySerializer(new StringRedisSerializer());
stringRedisTemplate.setValueSerializer(new StringRedisSerializer());
stringRedisTemplate.setConnectionFactory(redisConnectionFactory());
return stringRedisTemplate;
}



}
Empty file.
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package oncoding.concoder.exception;

import lombok.Getter;
import org.springframework.http.HttpStatus;

@Getter
public class CustomGlobalException extends RuntimeException {

private final ErrorCode errorCode;
private final String message;
private final HttpStatus status;
Comment on lines +10 to +11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중복 필드 삭제해야할것 같습니당~



public CustomGlobalException(ErrorCode errorCode){
this.errorCode = errorCode;
this.message = errorCode.getMessage();
this.status = errorCode.getStatus();
}


}
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
package oncoding.concoder.exception;

import lombok.extern.slf4j.Slf4j;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.web.HttpRequestMethodNotSupportedException;
import org.springframework.web.bind.MethodArgumentNotValidException;
import org.springframework.web.bind.annotation.ExceptionHandler;
import org.springframework.web.bind.annotation.RestControllerAdvice;

@Slf4j
@RestControllerAdvice
public class CustomGlobalExceptionHandler {

@ExceptionHandler(CustomGlobalException.class)
public ResponseEntity<ErrorResponse> handleCustomException(final CustomGlobalException globalException){
log.error("Custom Exception!", globalException);
return ResponseEntity.status(globalException.getErrorCode().getStatus().value())
.body(new ErrorResponse(globalException.getErrorCode()));
}

@ExceptionHandler(HttpRequestMethodNotSupportedException.class)
protected ResponseEntity<ErrorResponse> handleHttpRequestMethodNotSupportedException(final HttpRequestMethodNotSupportedException e) {
log.error("Method Not Supported!", e);
return ResponseEntity.status(ErrorCode.INTERNAL_SERVER_ERROR.getStatus().value())
.body(new ErrorResponse(ErrorCode.METHOD_NOT_ALLOWED));
}

@ExceptionHandler(MethodArgumentNotValidException.class)
protected ResponseEntity<ErrorResponse> handleNotBlankValid(MethodArgumentNotValidException e){
log.error("NotValid!", e);
Comment on lines +30 to +31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메서드 이름만 바꿔주세용~

return ResponseEntity.status(HttpStatus.BAD_REQUEST.value())
.body(new ErrorResponse(e.getFieldError().getDefaultMessage()));
}

@ExceptionHandler(Exception.class)
protected ResponseEntity<ErrorResponse> handleException(Exception e) {
log.error("Error!", e);
return ResponseEntity.status(ErrorCode.INTERNAL_SERVER_ERROR.getStatus().value())
.body(new ErrorResponse(ErrorCode.INTERNAL_SERVER_ERROR));
}

}
19 changes: 19 additions & 0 deletions src/main/java/oncoding/concoder/exception/ErrorCode.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package oncoding.concoder.exception;

import lombok.AllArgsConstructor;
import lombok.Getter;
import org.springframework.http.HttpStatus;

@Getter
@AllArgsConstructor
public enum ErrorCode {

BAD_REQUEST(HttpStatus.BAD_REQUEST, "잘못된 요청입니다."),
POSTS_NOT_FOUND(HttpStatus.NOT_FOUND, "해당 요청의 리소스를 찾을 수 없습니다."),
METHOD_NOT_ALLOWED(HttpStatus.METHOD_NOT_ALLOWED, "허용되지 않은 메서드입니다."),
INTERNAL_SERVER_ERROR(HttpStatus.INTERNAL_SERVER_ERROR, "내부 서버 오류입니다.");

private final HttpStatus status;
private final String message;

}
35 changes: 35 additions & 0 deletions src/main/java/oncoding/concoder/exception/ErrorResponse.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
package oncoding.concoder.exception;

import lombok.Builder;
import lombok.Getter;

@Getter
public class ErrorResponse {

private int status;
private String error;
private String code;
private String message;


@Builder
public ErrorResponse(ErrorCode errorCode){
this.status = errorCode.getStatus().value();
this.error= errorCode.getStatus().name();
this.code = errorCode.name();
this.message = errorCode.getMessage();
}

@Builder
public ErrorResponse(int status, String error, String code, String message) {
this.status = status;
this.error = error;
this.code = code;
this.message = message;
}

public ErrorResponse(String defaultMessage) {
this.message = defaultMessage;
}

}
Comment on lines +15 to +35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빌더랑 생성자 둘 중 하나 패턴으로만 통일하는게 이후 코드가 깔끔해질듯!

Empty file.
17 changes: 17 additions & 0 deletions src/main/java/oncoding/concoder/model/Category.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package oncoding.concoder.model;

import javax.persistence.Column;
import javax.persistence.Entity;
import javax.validation.constraints.NotNull;
import lombok.AccessLevel;
import lombok.Getter;
import lombok.NoArgsConstructor;

@Getter
@Entity
@NoArgsConstructor(access = AccessLevel.PROTECTED)
public class Category extends JpaBaseEntity {
@Column
@NotNull
private String name;
}
15 changes: 15 additions & 0 deletions src/main/java/oncoding/concoder/model/JpaBaseEntity.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package oncoding.concoder.model;

import java.util.UUID;
import javax.persistence.GeneratedValue;
import javax.persistence.Id;
import javax.persistence.MappedSuperclass;
import lombok.Getter;

@Getter
@MappedSuperclass
public class JpaBaseEntity {
@Id
@GeneratedValue
private UUID id;
}
17 changes: 17 additions & 0 deletions src/main/java/oncoding/concoder/model/Level.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package oncoding.concoder.model;

import javax.persistence.Column;
import javax.persistence.Entity;
import javax.validation.constraints.NotNull;
import lombok.AccessLevel;
import lombok.Getter;
import lombok.NoArgsConstructor;

@Getter
@Entity
@NoArgsConstructor(access = AccessLevel.PROTECTED)
public class Level extends JpaBaseEntity {
@Column
@NotNull
private String name;
}
41 changes: 41 additions & 0 deletions src/main/java/oncoding/concoder/model/Problem.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
package oncoding.concoder.model;

import java.util.ArrayList;
import java.util.List;
import javax.persistence.Column;
import javax.persistence.Entity;
import javax.persistence.FetchType;
import javax.persistence.ManyToOne;
import javax.persistence.OneToMany;
import javax.validation.constraints.NotNull;

import lombok.AccessLevel;
import lombok.Getter;
import lombok.NoArgsConstructor;

@Getter
@Entity
@NoArgsConstructor(access = AccessLevel.PROTECTED)
public class Problem extends JpaBaseEntity {
@Column(unique = true)
@NotNull
private Integer number;

@Column
@NotNull
private String title;

@Column
private Float rate;

@Column
@NotNull
private String content;

@ManyToOne(fetch = FetchType.EAGER)
private Level level;

@OneToMany(fetch = FetchType.EAGER, mappedBy = "problem")
private List<ProblemCategory> categories = new ArrayList<>();

}
18 changes: 18 additions & 0 deletions src/main/java/oncoding/concoder/model/ProblemCategory.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package oncoding.concoder.model;

import javax.persistence.Entity;
import javax.persistence.ManyToOne;
import lombok.AccessLevel;
import lombok.Getter;
import lombok.NoArgsConstructor;

@Getter
@Entity
@NoArgsConstructor(access = AccessLevel.PROTECTED)
public class ProblemCategory extends JpaBaseEntity {
@ManyToOne
private Problem problem;

@ManyToOne
private Category category;
}
35 changes: 35 additions & 0 deletions src/main/java/oncoding/concoder/model/Snapshot.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
package oncoding.concoder.model;

import java.time.LocalDateTime;
import javax.persistence.Column;
import javax.persistence.Entity;
import javax.persistence.EntityListeners;
import javax.validation.constraints.NotNull;
import lombok.AccessLevel;
import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Getter;
import lombok.NoArgsConstructor;
import org.springframework.data.annotation.CreatedDate;
import org.springframework.data.jpa.domain.support.AuditingEntityListener;

@Entity
@Getter
@Builder
@AllArgsConstructor
@NoArgsConstructor(access = AccessLevel.PROTECTED)
@EntityListeners(AuditingEntityListener.class)
public class Snapshot extends JpaBaseEntity {

@CreatedDate
@Column(updatable=false, nullable = false)
private LocalDateTime createdDate;

@Column
@NotNull
private String memo;

@Column
@NotNull
private String content;
}
Empty file.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package oncoding.concoder.repository;

import java.util.UUID;
import oncoding.concoder.model.Category;
import org.springframework.data.jpa.repository.JpaRepository;

public interface CategoryRepository extends JpaRepository<Category, UUID> {

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package oncoding.concoder.repository;

import java.util.UUID;
import oncoding.concoder.model.Level;
import org.springframework.data.jpa.repository.JpaRepository;

public interface LevelRepository extends JpaRepository<Level, UUID> {

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package oncoding.concoder.repository;

import java.util.UUID;
import oncoding.concoder.model.ProblemCategory;
import org.springframework.data.jpa.repository.JpaRepository;

public interface ProblemCategoryRepository extends JpaRepository<ProblemCategory, UUID> {

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package oncoding.concoder.repository;

import java.util.UUID;
import oncoding.concoder.model.Problem;
import org.springframework.data.jpa.repository.JpaRepository;

public interface ProblemRepository extends JpaRepository<Problem, UUID> {

}
5 changes: 4 additions & 1 deletion src/main/resources/application.yml
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@

spring:
redis:
host: localhost
port: 6379
Loading