Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping and static code analysis #15

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Housekeeping and static code analysis #15

merged 5 commits into from
Jan 18, 2024

Conversation

m-naumann
Copy link
Member

No description provided.

@m-naumann m-naumann requested a review from keroe as a code owner January 16, 2024 20:45
@m-naumann m-naumann force-pushed the feature/new_setup branch 2 times, most recently from f5faefe to 70e9fd4 Compare January 16, 2024 20:51
@m-naumann m-naumann changed the title Move to pyproject.toml and update CODEOWNERS Housekeeping and static code analysis Jan 16, 2024
@m-naumann
Copy link
Member Author

@fabikonsti I added some static code analysis and moved to the pyproject.toml. Maybe you can have a quick look. I can do the changes for your code also, afterwards, were only minor changes.

@fabikonsti
Copy link
Collaborator

fabikonsti commented Jan 18, 2024

@fabikonsti I added some static code analysis and moved to the pyproject.toml. Maybe you can have a quick look. I can do the changes for your code also, afterwards, were only minor changes.

@m-naumann Looks good. I think both PRs can be merged into the main. In the policy gradient PR, I added torch to the requirements.txt. This file does not exist anymore. Hence, we must add it to the pyproject.toml as well.

@m-naumann m-naumann merged commit 2dea7b8 into main Jan 18, 2024
2 checks passed
@m-naumann m-naumann deleted the feature/new_setup branch February 3, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants