Skip to content

Commit

Permalink
test: Remove unused code
Browse files Browse the repository at this point in the history
  • Loading branch information
KKoukiou committed Mar 11, 2024
1 parent f0891d8 commit 55bf1a0
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 33 deletions.
6 changes: 0 additions & 6 deletions test/helpers/installer.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,3 @@ def check_prerelease_info(self, is_expected=None):
self.browser.wait_visible("#betanag-icon")
else:
self.browser.wait_not_present("#betang-icon")

@log_step()
def quit(self):
self.browser.click("#installation-quit-btn")
self.browser.wait_visible("#installation-quit-confirm-dialog")
self.browser.click("#installation-quit-confirm-btn")
7 changes: 0 additions & 7 deletions test/helpers/language.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,6 @@ def locale_option_visible(self, locale, visible=True):
else:
self.browser.wait_not_present(f"#{self._step}-option-alpha-{locale}")

@log_step()
def locale_common_option_visible(self, locale, visible=True):
if visible:
self.browser.wait_visible(f"#{self._step}-option-common-{locale}")
else:
self.browser.wait_not_present(f"#{self._step}-option-common-{locale}")

@log_step(snapshot_before=True)
def check_selected_locale(self, locale):
self.browser.wait_visible(f"#{self._step}-option-alpha-{locale}.pf-m-selected")
Expand Down
19 changes: 0 additions & 19 deletions test/helpers/storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,6 @@ def wait_no_disks(self):
self.browser.wait_in_text("#next-helper-text",
"To continue, select the devices to install to.")

@log_step()
def wait_no_disks_detected(self):
self.browser.wait_in_text("#no-disks-detected-alert",
"No additional disks detected")

@log_step()
def wait_no_disks_detected_not_present(self):
self.browser.wait_not_present("#no-disks-detected-alert")
Expand Down Expand Up @@ -166,11 +161,6 @@ def __init__(self, browser, machine):
self.browser = browser
self.machine = machine

def get_disks(self):
output = self.machine.execute('list-harddrives')
for disk in output.splitlines():
yield disk.split()[0]

@log_step(docstring=True)
def unlock_storage_on_boot(self, password):
""" Add keyfile to unlock luks encrypted storage on boot """
Expand Down Expand Up @@ -499,12 +489,6 @@ def check_mountpoint_row_reformat(self, row, checked):
checked_selector = "input:checked" if checked else "input:not(:checked)"
self.browser.wait_visible(f"{self.table_row(row)} td[data-label='Reformat'] {checked_selector}")

def check_mountpoint_row_device_disabled(self, row):
self.browser.wait_visible(f"{self.table_row(row)} td[data-label='Device'] .pf-v5-c-select__toggle.pf-m-disabled")

def check_mountpoint_row_reformat_disabled(self, row):
self.browser.wait_visible(f"{self.table_row(row)} td[data-label='Reformat'] .pf-v5-c-check__input:disabled")

def add_mountpoint_row(self):
rows = self.browser.call_js_func("ph_count", '#mount-point-mapping-table tbody tr')
self.browser.click("button:contains('Add mount')")
Expand All @@ -516,9 +500,6 @@ def unlock_all_encrypted(self):
def unlock_all_encrypted_skip(self):
self.browser.click("button:contains('Skip')")

def assert_inline_error(self, text):
self.browser.wait_in_text(".pf-v5-c-alert.pf-m-inline.pf-m-danger", text)

def wait_mountpoint_table_column_helper(self, row, column, text=None, present=True):
if present:
self.browser.wait_in_text(f"#mount-point-mapping-table-row-{row}-{column} .pf-v5-c-helper-text__item.pf-m-error", text)
Expand Down
2 changes: 1 addition & 1 deletion test/webui_testvm.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def cmd_cli():
# print marker that the VM is ready; tests can poll for this to wait for the VM
print("RUNNING")

signal.signal(signal.SIGTERM, lambda sig, frame: machine.stop())
signal.signal(signal.SIGTERM, lambda _, frame: machine.stop())
signal.pause()
except KeyboardInterrupt:
machine.stop()
Expand Down

0 comments on commit 55bf1a0

Please sign in to comment.