-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate go codes on making dashboard-backend #84
Conversation
wsnet2-dashboard/backend/Dockerfile
Outdated
gopherjs_go="go1.19.13" \ | ||
protoc_ver="24.2" | ||
ENV PATH=/root/go/bin:/go/bin:$PATH \ | ||
GOPHERJS_GOROOT=/root/sdk/${gopherjs_go} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARGやENVってRUNみたいに \
で複数行繋いだ方がいいんでしたっけ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
レイヤーキャッシュが作られるわけじゃないのでどちらでも良いと思います。
ただ、ENVは複数書けるのですが、ARG複数は正式な書式じゃないみたいなので直します。
指定されたprotoc-gen-goのバージョンがGo1.23のものっぽい? |
@superkerokero |
fix: #82
dashboardのbackendのMakefileから、serverのコード生成を呼び出せるようにしました。
コード生成に必要なgo1.22とprotocをDockerfileでインストールするようにもしてあります。