forked from diasurgical/DevilutionX
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating Inventory Item Info Box #3
Open
kphoenix137
wants to merge
5
commits into
KP-Development:master
Choose a base branch
from
kphoenix137:qol-floatinginfobox
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Floating Inventory Item Info Box #3
kphoenix137
wants to merge
5
commits into
KP-Development:master
from
kphoenix137:qol-floatinginfobox
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbdb970
to
e90cd07
Compare
209f099
to
9267f98
Compare
8c10443
to
afce73c
Compare
746c991
to
41d6bae
Compare
Add GetLongestLineWidth() Move functions and update namespace anonymous Fix GetPanelPosition arguments for latest rebase Removed unnecessary Add function GetItemBonusColors() Add function GetItemRequirementColors() Fix y position bug After rebase to latest master, inventory item floating boxes started appearing 28 px too high Reorganize lines displayed Replace string searching functionality separate formatted strings Fix bugs Fix unique item display Completely inelegant solution, but it's the only thing that works Remove dead function Major refactor Allow stash floating info box Temp fix for bad width calculation Remove GetLongestLineWidth() Remove unncessary accidental line Remove changes from bad rebase Remove debug code Fix bad rebase fix bad rebase Fixed bug causing incorrect modified damage and armor values Fix gold pile text clang Red text "Not Identified" Fix durability colors Fix bug where normal items displayed 1 extra blank line Update Quest Unique Base Items for use with Floating Boxes Fix render order Alter quest base item AC Altered the base AC of quest items that have unique data that manually sets the durability. Therefore there shouldn't be any compatibility issues, and the end-user won't notice. This change was made to improve the colored numbers displayed for these items for AC. Fixes Items with values <= 0 wouldn't have those stats displayed at all. Also items with `IPL_AC_CURSE` weren't handled for text color. Fixed oversight where negative numbers for stats were underflowing for the text representation. Extra info with Shift Fix errors Remove bad shift detection method Add ability to map key for extra info Fix bitwise logic and Format value Add Game Info and fix no source Fixes and cheat detection Bad level detection Expand incompatible CF bits Fix regression with Harlequin Crest Fix pcursstashitem comparison Fix pcursstashitem comparison
50c7583
to
64a8117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR features a floating info box in the style of Diablo 2. This is the first step towards fully removing the classic control panel and replacing it with one that doesn't have the built-in Info Box.
Accidentally overwrote the original PR #2