Skip to content

Commit

Permalink
Update TODOs after extensive research into running containers with no…
Browse files Browse the repository at this point in the history
…n-root user
  • Loading branch information
KRMisha committed Apr 12, 2021
1 parent fee265a commit 19b6f14
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions docker-compose.argos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ services:
server:
command: argos
volumes:
- socket:/tmp/hivexplore # TODO: Document this directory # TODO: Check if /tmp/ is conventional for socket location inside container
- socket:/tmp/hivexplore # TODO: Document this directory

argos:
build: ./argos
image: hivexplore/argos
volumes:
- $XSOCKET:$XSOCKET
- $XAUTHORITY:$XAUTHORITY
- socket:/tmp/hivexplore # TODO: Document this directory
- socket:/tmp/hivexplore # TODO: Document this directory (in ARGoS README for make start commands)
environment:
DISPLAY: $DISPLAY
XAUTHORITY: $XAUTHORITY
Expand Down
5 changes: 2 additions & 3 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,9 @@ services:
ports:
- 5678:5678
volumes:
- logs:/hivexplore/logs # TODO: Change server code to use different directory (env variable maybe?)
- logs:/hivexplore/logs

volumes:
logs:
# TODO: Rename volumes?
# TODO: Fix permission issue, maybe this link: https://stackoverflow.com/questions/24288616/permission-denied-on-accessing-host-directory-in-docker


1 change: 1 addition & 0 deletions start.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ echo "Running Docker Compose"
docker-compose -f docker-compose.yml -f docker-compose.argos.yml up

# TODO: Arguments
# TODO: Add build option

0 comments on commit 19b6f14

Please sign in to comment.