Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove release_status property from all netkans #10283

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Nov 9, 2024

Motivation

The spec defines release_status as stable, testing, and development, in decreasing order of stability.

Currently no code looks at this value, which means we effectively treat all mods as stable today (since all mods will be installed for all users).

KSP-CKAN/CKAN#4159 is requesting that we finally follow through on the implicit promise of this property and make available a setting where users can choose their preferred mod stability. This cannot work if Scatterer, of all things, is telling us that it is a pre-pre-release only suited for the very most adventurous users.

Changes

Now all active netkans have non-stable values of release_status removed so we can start populating it with useful, meaningful metadata such as whether a release is marked as a pre-release on GitHub. No future netkan should set release_status unless it is actually a completely raw in-development mod whose developer is seeking early feedback (and probably some additional limitations such as a timeline for a full release and not being a dependency of any other mods).

We will probably need to do this in CKAN-meta as well, for users who insist on trying old game versions that are only compatible with historical mod releases indexed with these bogus values of release_status.

@HebaruSan HebaruSan added the Easy label Nov 9, 2024
@HebaruSan
Copy link
Member Author

The error is just kOSPropMonitor having inconsistent versions across hosts. Should still be fine to merge.

@HebaruSan HebaruSan merged commit 5f5a04d into KSP-CKAN:master Nov 9, 2024
0 of 2 checks passed
@HebaruSan HebaruSan deleted the fix/release-status branch November 9, 2024 02:52
@HebaruSan
Copy link
Member Author

HebaruSan commented Nov 9, 2024

For cleaning up CKAN-meta:

find . -path ./.git -prune -o -name \*.ckan -print0 | xargs -0 sed -i '/release_status.*\(testing\|development\)/d'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant