Remove release_status property from all netkans #10283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The spec defines
release_status
asstable
,testing
, anddevelopment
, in decreasing order of stability.Currently no code looks at this value, which means we effectively treat all mods as
stable
today (since all mods will be installed for all users).KSP-CKAN/CKAN#4159 is requesting that we finally follow through on the implicit promise of this property and make available a setting where users can choose their preferred mod stability. This cannot work if Scatterer, of all things, is telling us that it is a pre-pre-release only suited for the very most adventurous users.
Changes
Now all active netkans have non-
stable
values ofrelease_status
removed so we can start populating it with useful, meaningful metadata such as whether a release is marked as a pre-release on GitHub. No future netkan should setrelease_status
unless it is actually a completely raw in-development mod whose developer is seeking early feedback (and probably some additional limitations such as a timeline for a full release and not being a dependency of any other mods).We will probably need to do this in CKAN-meta as well, for users who insist on trying old game versions that are only compatible with historical mod releases indexed with these bogus values of
release_status
.