Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback Issued (jtuv + jmaragna) #2611

Closed
wants to merge 11 commits into from
Closed

Conversation

jackma-00
Copy link
Contributor

@jackma-00 jackma-00 commented Oct 7, 2024

Assignment Proposal

Title

Feedback for Executable Tutorial Managing project dependencies with Devbox

Names and KTH ID

Deadline

  • Task 2

Category

  • Feedback

Description

We will provide feedback to the Executable Tutorial Managing project dependencies with Devbox made by Íñigo Aréjula Aísa and
Pere Mateu Raventós on Devbox.

Done

Feedback:

Introduction:
The introduction is clear and sets a solid foundation for the tutorial.
Typographical Errors:
There are some typos that should be addressed for better clarity.
Understanding DevBox:
The section on trying DevBox could be clearer. Specifically, is the devbox run py command intended to execute a script defined for installing dependencies?
Understanding the devbox.json File:
This section is now clear and very insightful. I found it quite impressive!
Create Your Own Script - Part 1:
This part was very helpful. I successfully created my own script independently, which greatly enhanced my understanding.
Create Your Own Script - Part 2:
Should we also consider including the init hook in our script for completeness?
DevBox Integration with CI/CD:
I appreciate the emphasis on maintaining consistency within the development environment.
Production Environment Considerations:
How can we effectively transition DevBox into the production environment? Further guidance on this would be valuable.

@dd2482-bot
Copy link
Collaborator

Readme is not correctly formatted
Need exactly: ['Assignment Proposal', 'Title', 'Names and KTH ID', 'Deadline', 'Category', 'Description']

Got: ['Assignment Proposal', 'Title', 'Names and KTH ID', 'Deadline', 'Category', 'Description', 'Done']

@jackma-00
Copy link
Contributor Author

@Glassar Here is our PR for the Feedback. In the Description under the section "Done" I include my feedback. Please proceed to merge it with yours.

@jackma-00
Copy link
Contributor Author

@arejula27 @peremateu Please find our feedback on your executable tutorial under the section "Done" in the description of the current PR.

@jackma-00 jackma-00 closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants