Chore/upgrade/kth cortina block 7 #408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsandstrom
requested review from
belanglos,
amirhossein-haerian,
axelbjo and
allazis
as code owners
amirhossein-haerian
approved these changes
Feb 26, 2025
axelbjo
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
We have made a lot of changes to the package that fetches
blocksfrom cortina.It has been a chaotic journey, but now we have somewhat of a "finished" version.
Before, we had the middleware in one package and most of the logic in another, now everything is in @kth/cortina-block.
A lot of its old settings is no longer used since we changed all apps to Style 10 last spring.
I made this PR as an example for you, and to test if it works well with your apps.
This should be the most demanding one, since it uses a few student-specific blocks.
(Have not been able to do a full test since I lack all settings on localhost, but I can see the studentMegaMenu render)