Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(OAuth): fix google login #43

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Fix(OAuth): fix google login #43

merged 4 commits into from
Jul 24, 2024

Conversation

rlawngP91
Copy link
Contributor

@rlawngP91 rlawngP91 commented Jul 23, 2024 •
edited
Loading

Resolves #42

๐Ÿ“Œ ๊ฐœ์š”

google ์œ ์ €์ •๋ณด ๊ฐ€์ ธ์˜ค๋Š” ๋ถ€๋ถ„์—์„œ ์˜ค๋ฅ˜๋ฐœ๊ฒฌ ์ˆ˜์ •ํ•จ
google ์œ ์ €์ •๋ณด๋กœ ์ถ”๊ฐ€์ •๋ณด๋กœ ์ž…๋ ฅํ•˜๋Š” ๊ณผ์ •์—์„œ email๊ณผ platform id์˜ column์„ค์ •์ด ๋„ˆ๋ฌด ์ž‘๊ฒŒ ๋˜์–ด ์žˆ์–ด ์ˆ˜์ •ํ•จ

๐Ÿ“ PR ์œ ํ˜•

์–ด๋–ค ๋ณ€๊ฒฝ ์‚ฌํ•ญ์ด ์žˆ๋‚˜์š”?

  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ์ฝ”๋“œ์— ์˜ํ–ฅ์„ ์ฃผ์ง€ ์•Š๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ(์˜คํƒ€ ์ˆ˜์ •, ๋ณ€์ˆ˜๋ช… ๋ณ€๊ฒฝ)
  • ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
  • ์ฃผ์„ ์ถ”๊ฐ€ ๋ฐ ์ˆ˜์ •
  • ๋ฌธ์„œ ์ˆ˜์ •
  • ํ…Œ์ŠคํŠธ ์ถ”๊ฐ€, ํ…Œ์ŠคํŠธ ๋ฆฌํŒฉํ† ๋ง
  • ๋นŒ๋“œ ๋ถ€๋ถ„ ํ˜น์€ ํŒจํ‚ค์ง€ ๋งค๋‹ˆ์ € ์ˆ˜์ •
  • ํŒŒ์ผ ํ˜น์€ ํด๋” ์‚ญ์ œ

โœ” PR Checklist

PR์ด ๋‹ค์Œ ์š”๊ตฌ ์‚ฌํ•ญ์„ ์ถฉ์กฑํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.

  • ์ปค๋ฐ‹ ๋ฉ”์‹œ์ง€ ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค. Commit message convention ์ฐธ๊ณ  (Ctrl + ํด๋ฆญํ•˜์„ธ์š”.)
  • ๋ณ€๊ฒฝ ์‚ฌํ•ญ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ๋ฅผ ํ–ˆ์Šต๋‹ˆ๋‹ค.(๋ฒ„๊ทธ ์ˆ˜์ •/๊ธฐ๋Šฅ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ).

@rlawngP91 rlawngP91 self-assigned this Jul 23, 2024
@rlawngP91 rlawngP91 added the โœ”Fix Changes that directly address bugs, errors, or any unintended behavior label Jul 23, 2024
yunjeongiya
yunjeongiya requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@yunjeongiya yunjeongiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฐ”๋กœ ๊ณ ์ณ์ ธ์„œ ๋‹คํ–‰์ด๋„ค์š”! .DS_Store ํŒŒ์ผ๋“ค gitignore ์ถ”๊ฐ€ํ•ด์„œ ๋‚ด๋ ค์ฃผ์‹  ํ›„์— ๋จธ์ง€ํ•˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค!

.DS_Store Outdated Show resolved Hide resolved
src/main/java/com/mapu/infra/oauth/google/GoogleUserService.java Show resolved Hide resolved
yeonjookang
yeonjookang approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@yeonjookang yeonjookang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/main/java/com/mapu/infra/oauth/google/GoogleUserService.java Show resolved Hide resolved
@rlawngP91 rlawngP91 merged commit 1008371 into dev Jul 24, 2024
1 check passed
@rlawngP91 rlawngP91 deleted the fix/42-fix-google-login branch July 24, 2024 05:01
ssilver01
ssilver01 reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@ssilver01 ssilver01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssilver01 ssilver01 ssilver01 left review comments

@yunjeongiya yunjeongiya yunjeongiya approved these changes

@yeonjookang yeonjookang yeonjookang approved these changes

Assignees

@rlawngP91 rlawngP91

Labels
โœ”Fix Changes that directly address bugs, errors, or any unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix(OAuth): google social login ์˜ค๋ฅ˜
4 participants
@rlawngP91 @yunjeongiya @ssilver01 @yeonjookang