Fix(Map): search Api paging 오류 & dev branch merge 오류 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlawngP91
added
the
✔Fix
yeonjookang
reviewed
Aug 7, 2024
There was a problem hiding this comment.
getMapList의 마지막에 return null 이 아니라 예외가 터져야하지 않을까요?
There was a problem hiding this comment.
아직 exception을 다 안 만들어서.. 일단 이부분은 map 예외처리할 때 모두 해놓을게요~!
There was a problem hiding this comment.
GetMapListByDate, GetMapListByDate의 메소드 맨 앞에 소문자로 시작해야할 것 같아요
There was a problem hiding this comment.
날짜순은 페이징 처리가 잘되고, 랜덤순이 페이징 처리가 안되는건가요?
There was a problem hiding this comment.
둘다 잘 되는데 주석처리를 안지웠네용ㅎㅎ
rlawngP91
commented
Aug 7, 2024
There was a problem hiding this comment.
둘다 잘 되는데 주석처리를 안지웠네용ㅎㅎ
There was a problem hiding this comment.
아직 exception을 다 안 만들어서.. 일단 이부분은 map 예외처리할 때 모두 해놓을게요~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #59
📌 개요
/map/search paging 처리 오류 수정
📝 PR 유형
어떤 변경 사항이 있나요?
✔ PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.