fix: restore SBOM creation #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update to `actions/upload-artifact` v4 introduces a breaking change: > Uploading to the same named Artifact multiple times. > > Due to how Artifacts are created in this new version, it is no longer > possible to upload to the same named Artifact multiple times. > You must either split the uploads into multiple Artifacts with different names, > or only upload once. > Otherwise you will encounter an error. This is good security improvement. This commit fixes the build failures we've seen by: - Uploading x86_64 and ARM64 SBOMs as individual artifacts - When creating the GitHub release, download all the artifacts produced during the run. The pre-existing code was already looking for the specific SBOM files Signed-off-by: Flavio Castelli <[email protected]>
flavio
force-pushed
the
fix-sbom-creation
branch
from
782fec9
to
3f257d8
Compare
|
There was an updated of the "download artifact action" that simplifies things. I've updated the PR to consume this action. I've also tested the change on my fork. Everything is working fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update to
actions/upload-artifactv4 introduces a breaking change:This is good security improvement.
This commit fixes the build failures we've seen by: