Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kagglehub to TPU image. #1341

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Add kagglehub to TPU image. #1341

merged 6 commits into from
Dec 14, 2023

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Dec 13, 2023

I also deleted the unused cloudbuild.yaml file and the out-dated README for it.

http://b/316184178

@rosbo rosbo requested a review from djherbis December 13, 2023 20:04
tpu/Dockerfile Outdated
@@ -62,6 +62,9 @@ RUN pip install tensorflow_hub https://storage.googleapis.com/cloud-tpu-tpuvm-ar
# Tensorflow libtpu:
RUN curl --output /lib/libtpu.so https://storage.googleapis.com/cloud-tpu-tpuvm-artifacts/libtpu/${TF_LIBTPU_VERSION}/libtpu.so

# Install kagglehub library
RUN pip install kagglehub
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we don't clear the cache at the end of each layer which means the image will be larger. Should we add that? Any reason for now doing it like we do for CPU/GPU?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add that, but this image is tiny by comparison already.

Can we move this into the pip install above by just adding it to the list of packages? It can go on its own line at the end.

This image is intended to only have 1 pip install to prevent any incompatibilities across the small package set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Done.

Copy link
Contributor

@djherbis djherbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rosbo rosbo merged commit d1d0e2e into main Dec 14, 2023
3 checks passed
@rosbo rosbo deleted the kagglehub-tpu-image branch December 14, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants