Use kagglehub inside Kaggle Notebook for tensorflow_hub #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if you try using tensorflow_hub with a kaggle.com URL inside a Kaggle notebook but the model isn't attached you would get an error message telling you to attach the model. With this change, we are calling `kagglehub` instead and will attach the model for the user if it is missing. http://b/311184735
rosbo
commented
Dec 14, 2023
|
|
||
| def _is_on_kaggle_notebook(): | ||
| return os.getenv("KAGGLE_CONTAINER_NAME") != None | ||
| return os.getenv("KAGGLE_KERNEL_RUN_TYPE") != None |
There was a problem hiding this comment.
Using the same environment variable than kagglehub. Both are set so this is a NoOp: https://github.com/Kaggle/kagglehub/blob/c1b6e00226ca952b1d93d05089980dfe233f0163/src/kagglehub/kaggle_cache_resolver.py#L29C1-L29C1
rosbo
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Philmod
approved these changes
Dec 15, 2023
| "mountSlug": mount_slug, | ||
| }, | ||
| }), "utf-8")) | ||
| else: |
There was a problem hiding this comment.
nit: start with this case to reduce tabs:
if not self.path.endswith(...):
self.send_response(404)
...
content_length = int(self.headers["Content-Length"])
...There was a problem hiding this comment.
I prefer to keep it this way because we may add new elif cases for other paths and we would want to fail only in the else at the bottom.
rosbo
commented
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use kagglehub inside Kaggle Notebook for tensorflow_hub
Currently, if you try using tensorflow_hub with a kaggle.com URL inside
a Kaggle notebook but the model isn't attached you would get an error
message telling you to attach the model.
With this change, we are calling
kagglehubinstead and will attach themodel for the user if it is missing.
http://b/311184735