Import 64-bit fixes and rewinddir from dcload-ip #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fixed by BlueCrab in 2013 for dcload-ip and just never made it into dcload-serial. The issue is that the original dcload was set up to just sent the raw host-side `DIR *` over to the target. This worked fine when those pointers were 32-bit, but as hosts moved to 64-bit it simply broke. Now instead, we keep a cache of those pointers and assign an fd before sending over to the target. This is maintaining the offset like dcload-ip, but a PR will be forthcoming to update fs_dcload to undo the hack on the dc side.
|
Force pushed just to fix the commit message where I'd mentioned rewinddir for no good reason. The reference was because this is implementing the 64-bit fix commit ( KallistiOS/dcload-ip@1105551 ) and addition of rewinddir which has that fix incorporated ( KallistiOS/dcload-ip@b552f03 ). |
This was referenced Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details in the commit notes. This should fix directory reading in dc-load serial on 64-bit hosts (pretty much everything). The biggest additional changes were that I set the max opened dirs to be 512 (since it's the host side we don't need to be so stingy with memory) and I had to make one commit prior to the main update in order to be able to compile on gcc14 and up.