Convert ContainedSpan
to ContainedSpan<T>
#187
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts ContainedSpan to
ContainedSpan<T>
, and cleans up all the fields to do so.This PR is quite big, with a lot of busywork, so a few highlights:
ContainedSpan<T>
, with a new fieldinner
, andtokens
split intostart
andend
node(full_range)
andvisit(contains)
are now removedA few things to point out which I was not sure about:
(&TokenReference, &TokenReference)
rather than a ContainedSpan. Is it worth keeping these two methods separate, or just creating a new method which returns theContainedSpan<T>
? [Same issue with the corresponding "mutator" methods]Still TODO:
This PR also fixes #161 (supersedes #166)