Ensure an error is emitted when parsing a stmt after a last stmt in the top level block #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure an error is emitted if there is a statement after a last statement
Kampfkarren
approved these changes
Jun 28, 2024
full-moon/src/ast/parser_structs.rs
Outdated
| @@ -315,6 +317,14 @@ impl AstResult { | |||
| continue; | |||
| } | |||
|
|
|||
| if block_has_last_stmt { | |||
| use crate::node::Node; | |||
There was a problem hiding this comment.
Let's just put this in the beginning
There was a problem hiding this comment.
I was lazy because it clashes with start_position / end_position on TokenReference. If we stick it at the top we need to disambiguate all other usages
There was a problem hiding this comment.
Done in last commit, wasn't that bad. Can revert if we want to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is code that "merges" two top level blocks when performing initial parsing. This code does not account for the fact that a stmt parsed after a last stmt is invalid syntax. We extend it to ensure an error is reported in this case.
Note that we do not resolve the problem where the stmts after the last stmt "teleport" in front of the last stmt in the AST. That is more difficult to sort without restructuring the AST. However this was originally parsed as invalid syntax so we now at least emit an error and do not guarantee the state of an invalid syntax tree.
Partially resolves #298