Add deprecated fixer

Kampfkarren · Oct 14, 2023 · 47afa03 · 47afa03
1 parent 1c519dc
commit 47afa03
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 1 deletion.
diff --git a/selene-lib/src/lints/deprecated.rs b/selene-lib/src/lints/deprecated.rs
@@ -115,8 +115,11 @@ impl<'a> DeprecatedVisitor<'a> {
 
             let mut notes = vec![deprecated.message.to_owned()];
 
+            let mut fixed_code = None;
+
             if let Some(replace_with) = deprecated.try_instead(parameters) {
                 notes.push(format!("try: {replace_with}"));
+                fixed_code = Some(replace_with);
             }
 
             self.diagnostics.push(Diagnostic::new_complete(
@@ -128,7 +131,7 @@ impl<'a> DeprecatedVisitor<'a> {
                 Label::from_node(node, None),
                 notes,
                 Vec::new(),
-                None,
+                fixed_code,
             ));
         }
     }

diff --git a/selene-lib/tests/lints/deprecated/deprecated_fields.fixed.diff b/selene-lib/tests/lints/deprecated/deprecated_fields.fixed.diff
@@ -0,0 +1,3 @@
+ local _ = this.is_deprecated
+ local _ = all_of_this.is_deprecated
+ local _ = all_of_this.even.deeper.is_deprecated
diff --git a/selene-lib/tests/lints/deprecated/deprecated_functions.fixed.diff b/selene-lib/tests/lints/deprecated/deprecated_functions.fixed.diff
@@ -0,0 +1,5 @@
+ table.foreach({}, function(k, v) end)
+-print(table.getn(x))
++print(#x)
+
+ table.foreach({}, 3)
diff --git a/selene-lib/tests/lints/deprecated/specific_allow.fixed.diff b/selene-lib/tests/lints/deprecated/specific_allow.fixed.diff
@@ -0,0 +1,7 @@
+ deprecated_allowed()
+ deprecated_blocked()
+
+ more.deprecated_allowed()
+ wow.extra.deprecated_allowed()
+
+ deprecated_allowed.more()
diff --git a/selene-lib/tests/lints/deprecated/toml_forwards_compatibility.fixed.diff b/selene-lib/tests/lints/deprecated/toml_forwards_compatibility.fixed.diff
@@ -0,0 +1,2 @@
+ -- Tests that the old TOML format is unchanged
+ print(this_is.deprecated)