Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint against approximated constants #574

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Lint against approximated constants #574

wants to merge 6 commits into from

Conversation

chriscerie
Copy link
Collaborator

Closes #573.

Kampfkarren
Kampfkarren requested changes Apr 28, 2024
View reviewed changes
Copy link
Owner

@Kampfkarren Kampfkarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code all looks fine, but can we fully name it "approximated_constants"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kampfkarren Kampfkarren Kampfkarren requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint against approximated constants
2 participants
@chriscerie @Kampfkarren