Add "repeat until correct" option #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a "repeat until correct" option to the user settings, which lets users repeat the same review item when they get it wrong or ignore it, until they get it right. The feature is inspired by a setting of Reorder Omega for WaniKani, which I always use, because it can be annoying when an incorrect/ignored item gets shuffled back in the review queue. It saves time if the user can just try again immediately, especially when it's just a typo that should be ignored.
When the user setting is active,
quiz.session.current.rotate())is simply not dispatched after an incorrectly answered or ignored review item, so the current review item is not moved in the queue.The new user setting also needs to be stored, see Kaniwani/kw-backend#505.