Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified esis.flights.f1.optics.models.design_full() to include the grating efficiency model. #8

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

byrdie
Copy link
Contributor

@byrdie byrdie commented Jul 20, 2024

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
… grating efficiency model.
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.80%. Comparing base (5bd48bb) to head (0efa5f6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   17.75%   17.80%   +0.04%     
==========================================
  Files         184      184              
  Lines        8621     8626       +5     
==========================================
+ Hits         1531     1536       +5     
  Misses       7090     7090              
Flag Coverage Δ
unittests 17.80% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byrdie byrdie merged commit e8c7e83 into master Jul 20, 2024
8 checks passed
@byrdie byrdie deleted the feature/grating-efficiency branch July 20, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant