chore(uniforms-patternfly): Port @kie-tools/uniforms-patternfly #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
added
help wanted
lordrip
force-pushed
the
feat/uniforms-patternfly
branch
from
090796a
to
c32ba5b
Compare
|
At least one test is passing now 😄 |
lordrip
force-pushed
the
feat/uniforms-patternfly
branch
from
5ab60a4
to
c183afa
Compare
Changes: - Add testEnvironment=jsdom - Remove resolution for uniforms, in order to let @kie-tools/uniforms-patternfly get its own version
lordrip
force-pushed
the
feat/uniforms-patternfly
branch
3 times, most recently
from
71586d1
to
b03ff4e
Compare
lordrip
force-pushed
the
feat/uniforms-patternfly
branch
2 times, most recently
from
d49bbc4
to
03fcbbe
Compare
lordrip
force-pushed
the
feat/uniforms-patternfly
branch
from
03fcbbe
to
cebccca
Compare
lordrip
pushed a commit
to lordrip/kaoto
that referenced
this pull request
Aug 30, 2024
Fixes: KaotoIO#143 Also removed poc-dnd-line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
@kie-tools/uniforms-patternflypackage depends on@patternfly v4.Many packages from
@kie-toolsdepend on@kie-tools/uniforms-patternflyprovided from its workspace, this prevents upgrading it to@patternfly v5since this will mean upgrading all dependencies at once.Goal
This pull request aims to temporarily bring the
@kie-tools/uniforms-patternflypackage, make the necessary upgrades to@patternfly v5, and publish it under a different scope to provide an escape hatch for upgrading individual packages one by one while supporting thekaoto-nextuse cases.Todo
@kie-tools/uniforms-patternflytokaoto-next@patternflytov5uniformstov4kaoto-nextTodo for an upcoming pull request (https://github.com/KaotoIO/uniforms-patternfly)
@kaoto-nextscope, f.i.@kaoto-next/uniforms-patternflyeslintwith the same config as the upstream repositoryNotes
This pull request is a prerequisite for:
Related issues:
v4tov5onkie-toolsapache/incubator-kie-issues#468